Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #9

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Develop #9

wants to merge 15 commits into from

Conversation

tbrisco
Copy link

@tbrisco tbrisco commented Dec 16, 2014

Hi Bruno,

I forked your 2.2.0.0 branch. It kept throwing errors while attempting to deploy to mysql directly. I am working in version 5.6.21 of MySql. The functional change I made was in mysql_apply.vm. The GetDate() syntax doesn't exist in 5.6.21 - it wanted current_timestamp(). I also upgraded NAnt since my CI server uses 0.92, but I didn't make any changes to your code that require it. There are more modified files than this since your repo has mixed line breaks. I converted as many as I could do automatically to UNIX line feeds and committed those.

Although the code builds, it doesn't run successfully on all machines. The reason for this is that it relies on a bunch of assemblies that you must have installed in your GAC. I believe it is a better practice to distribute them directly. If you don't want to do that, I suggest at least documenting the required assemblies (this is another reason that I upgraded NAnt).

I found your project because I was looking for a way to automate mysql deployment so your code is VERY useful. It was disappointing to me that the examples were all MSSQL based. Your introduction also talks about how the code can be called through msbuild and nant, yet doesn't provide a clear example.

Regards,
Tony

@brunomlopes
Copy link
Owner

Hi Tony,

Thanks for the PR. Just to let you know that I'll try and look into this in the next few days, ok?

Bruno

@tbrisco
Copy link
Author

tbrisco commented Dec 17, 2014

Thanks, Bruno.

I didn't mean to be harsh in my comments. I really appreciate the work you
have done in bringing this functionality to the .NET world for MySQL.

I will be working on fixing some of the build and/or run issues caused by
components installed in the GAC over the next month. I will send
additional pull requests as I get them committed.

Regards,
Tony

On Wed, Dec 17, 2014 at 4:21 AM, Bruno Lopes [email protected]
wrote:

Hi Tony,

Thanks for the PR. Just to let you know that I'll try and look into this
in the next few days, ok?

Bruno


Reply to this email directly or view it on GitHub
#9 (comment)
.

Tony Briscolino
Technology Services Manager
The Mx Group

T 630-654-0170 x 147
7020 High Grove Blvd.
Burr Ridge, IL 60527
www.TheMxGroup.com http://www.themxgroup.com/

We help
companies
excite markets,
engage customers,
effect sales &
embed value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants